Fix for Millionaire demo project#29
Merged
oceans404 merged 4 commits intoNillionNetwork:mainfrom Jun 11, 2024
VladLeustean:main
Merged
Fix for Millionaire demo project#29oceans404 merged 4 commits intoNillionNetwork:mainfrom VladLeustean:main
oceans404 merged 4 commits intoNillionNetwork:mainfrom
VladLeustean:main
Conversation
Fixed the pathing for the .nada.bin file
Updated the .nada.bin path to use the Config file path. Approach similar to one used in the following project: /nillion-python-starter/examples_and_tutorials/core_concept_multi_party_compute
missed paranthesis
Forgot to add CONFIG_PROGRAM_NAME variable
Contributor
Author
Contributor
|
nice! thanks for opening the issue and contributing a PR fix @VladLeustean |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I found this pathing bug while doing the Millionaire demo project in the Nillion docs. I did this fix for it and Steph encouraged me to raise an issue and do a PR for it.
Here is the issue I raised:
#28
This is my commit to fix it, it updates the config file to hold the "CONFIG_PROGRAM_NAME="millionaires"" variable. It also sets the path variable inside 01_store_secret_party1.py to use the compiled .nada.bin file in the programs-compile directory.
I saw this method being used in the nillion-python-starter/examples_and_tutorials/core_concept_multi_party_compute project.
ETH wallet
0x8Ed084fe1502dAF70A1085e1AD6941DbE52D08c8