Avoid unnecessary commands when querying the retry counts

[robinkrahl]

libnitrokey/NitrokeyManager.cc

Lines 788 to 802 in d753488

	uint8_t NitrokeyManager::get_user_retry_count() {
	if(device->get_device_model() == DeviceModel::STORAGE){
	stick20::GetDeviceStatus::CommandTransaction::run(device);
	}
	auto response = GetUserPasswordRetryCount::CommandTransaction::run(device);
	return response.data().password_retry_count;
	}
	uint8_t NitrokeyManager::get_admin_retry_count() {
	if(device->get_device_model() == DeviceModel::STORAGE){
	stick20::GetDeviceStatus::CommandTransaction::run(device);
	}
	auto response = GetPasswordRetryCount::CommandTransaction::run(device);
	return response.data().password_retry_count;
	}

Isn’t it possible to directly use the response of GetDeviceStatus for Storage devices?

[szszszsz]

Good catch! Indeed, on the firmware side the status call refreshes the smart card counters, and seems to return the correct values. I guess this was supposed to be an early return for the Nitrokey Storage, but somehow was not implemented.

Firmware side implementation: https://github.com/Nitrokey/nitrokey-storage-firmware/blob/f376b081d5900f9e494f74230f79df7552ae8e1f/src/USER_INTERFACE/html_io.c#L575-L588