Test and document builtins.baseNameOf, improve internal baseNameOf()

[roberth]

Motivation

baseNameOf is weird. Deal with it.

Context

Found while at code related to #10303

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

[Ericson2314]

FWIW programming language standard libraries tend not to remove any slashes:

• https://hackage.haskell.org/package/filepath-1.5.2.0/docs/System-FilePath.html#v:takeBaseName
• https://docs.python.org/3/library/os.path.html
• https://en.cppreference.com/w/cpp/filesystem/path/filename

Perhaps we will eventually (not now!) migrate our internal baseName to work that way too, e.g. as part of #9205. But totally that agreed removing all trailing slashes is more consistent that removing just one.

[flokli]

This changed hashing behaviour, see https://cl.snix.dev/c/snix/+/31164

[xokdvium]

It does not, there was a subsequent regression.

[xokdvium]

Ah sorry, thinking of unrelated fuckup of dirOf #14515