exportReferencesGraph: Handle heterogeneous arrays#14189
Merged
Conversation
edolstra
added
backport 2.28-maintenance
github-actions
Bot
added
the
with-tests
Contributor
|
Any idea when this was broken? |
edolstra
removed
the
backport 2.28-maintenance
Member
Author
|
Since 2.29. There was a partial fix before (#13256) but it didn't handle the case of nested arrays. |
Member
|
It was pretty frustrating to bisect this since it kept pointing to that same area we fixed last time 😅 Luckily, Eelco was able to peek inside the unhappy-value and figure out what was wrong before I lost any more hair. (Downstream ref: DeterminateSystems#221) |
xokdvium
approved these changes
Oct 8, 2025
edolstra
force-pushed
the
fix-exportReferencesGraph
branch
from
68fca5c to
87c6b02
Compare
Ericson2314
reviewed
Oct 8, 2025
Ericson2314
approved these changes
Oct 8, 2025
edolstra
force-pushed
the
fix-exportReferencesGraph
branch
from
87c6b02 to
e60ff9c
Compare
This barfed with error: [json.exception.type_error.302] type must be string, but is array on `nix build github:malt3/bazel-env#bazel-env` because it has a `exportReferencesGraph` with a value like `["string",...["string"]]`.
edolstra
force-pushed
the
fix-exportReferencesGraph
branch
from
e60ff9c to
94f410b
Compare
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.29-maintenance
git worktree add -d .worktree/backport-14189-to-2.29-maintenance origin/2.29-maintenance
cd .worktree/backport-14189-to-2.29-maintenance
git switch --create backport-14189-to-2.29-maintenance
git cherry-pick -x 94f410b628ede2ecec6ed06cbb0f62e1f9d9e8cf |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.30-maintenance
git worktree add -d .worktree/backport-14189-to-2.30-maintenance origin/2.30-maintenance
cd .worktree/backport-14189-to-2.30-maintenance
git switch --create backport-14189-to-2.30-maintenance
git cherry-pick -x 94f410b628ede2ecec6ed06cbb0f62e1f9d9e8cf |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
edolstra
added a commit
to DeterminateSystems/nix-src
that referenced
this pull request
Oct 9, 2025
github-merge-queue Bot
pushed a commit
to DeterminateSystems/nix-src
that referenced
this pull request
Oct 9, 2025
Backport changes from upstream NixOS#14189
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
malt3
added a commit
to malt3/bazel-env
that referenced
this pull request
Dec 4, 2025
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This barfed with
on
nix build github:malt3/bazel-env#bazel-envbecause it has aexportReferencesGraphwith a value like["string",...["string"]].Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.