libmain/shared: Restore MiB units for printMissing#14455
Conversation
Partially reverts 584a8e8. See the code comment for details. Seems like reverting this change for now will have the least fallout.
|
Not sure if this is a good idea, but that's one option. |
|
I think we should wait for a change and release in nom: #14364 (comment) and then update both packages in nixpkgs together. Ideally, nom would support the old and new format. |
|
I don't think it's necessary to revert this on master. It's sufficient to revert it on the release branches. In general, programs shouldn't expect Nix's stderr messages to have any particular format. |
|
This PR is unfortunate I think. Would it not be easier to fix nom ? Is there an open issue for why ActivityLog is not in the JSON? |
maralorn/nix-output-monitor#206 I think it's fine if we changes this for releases and than have nom to catch up when we have a proper fix. I don't think fixing nom and making sure nix releases don't change behavior too much have to be mutual exclusive, the discussion what we can fix in the JSON output can be done afterwards. Looking at the popularity of nix-output-monitor also indicates that it's not just a few people using it. |
|
FYI, I've reverted #14364 on the maintenance branches. |
From my random sampling of looking on screens at nix cons a lot of users use nom, not just a few. 😆
Done |
Motivation
Partially reverts 584a8e8. See the code comment for details. Seems like reverting this change for now will have the least fallout.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.