Skip to content

libmain/shared: Restore MiB units for printMissing#14455

Closed
xokdvium wants to merge 1 commit into
masterfrom
print-missing-always-mib
Closed

libmain/shared: Restore MiB units for printMissing#14455
xokdvium wants to merge 1 commit into
masterfrom
print-missing-always-mib

Conversation

@xokdvium
Copy link
Copy Markdown
Contributor

@xokdvium xokdvium commented Nov 3, 2025

Motivation

Partially reverts 584a8e8. See the code comment for details. Seems like reverting this change for now will have the least fallout.

Context


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

Partially reverts 584a8e8. See the code
comment for details. Seems like reverting this change for now will have
the least fallout.
@xokdvium xokdvium requested a review from edolstra as a code owner November 3, 2025 10:25
@xokdvium xokdvium added backport 2.30-maintenance Automatically creates a PR against the branch backport 2.31-maintenance Automatically creates a PR against the branch backport 2.32-maintenance Automatically creates a PR against the branch labels Nov 3, 2025
@xokdvium
Copy link
Copy Markdown
Contributor Author

xokdvium commented Nov 3, 2025

Not sure if this is a good idea, but that's one option.

@MarcelCoding
Copy link
Copy Markdown
Member

MarcelCoding commented Nov 3, 2025

I think we should wait for a change and release in nom: #14364 (comment) and then update both packages in nixpkgs together. Ideally, nom would support the old and new format.

@edolstra
Copy link
Copy Markdown
Member

edolstra commented Nov 3, 2025

I don't think it's necessary to revert this on master. It's sufficient to revert it on the release branches. In general, programs shouldn't expect Nix's stderr messages to have any particular format.

@fzakaria
Copy link
Copy Markdown
Contributor

fzakaria commented Nov 3, 2025

This PR is unfortunate I think.
This goes backwards for all Nix users for the few that use nom.

Would it not be easier to fix nom ?

Is there an open issue for why ActivityLog is not in the JSON?
(Maybe with some verbosity it should be?)

@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Nov 3, 2025

This PR is unfortunate I think. This goes backwards for all Nix users for the few that use nom.

Would it not be easier to fix nom ?

Is there an open issue for why ActivityLog is not in the JSON? (Maybe with some verbosity it should be?)

maralorn/nix-output-monitor#206

I think it's fine if we changes this for releases and than have nom to catch up when we have a proper fix. I don't think fixing nom and making sure nix releases don't change behavior too much have to be mutual exclusive, the discussion what we can fix in the JSON output can be done afterwards. Looking at the popularity of nix-output-monitor also indicates that it's not just a few people using it.

@edolstra
Copy link
Copy Markdown
Member

edolstra commented Nov 6, 2025

FYI, I've reverted #14364 on the maintenance branches.

@edolstra edolstra removed backport 2.30-maintenance Automatically creates a PR against the branch backport 2.31-maintenance Automatically creates a PR against the branch backport 2.32-maintenance Automatically creates a PR against the branch labels Nov 6, 2025
@xokdvium xokdvium closed this Nov 6, 2025
@xokdvium xokdvium deleted the print-missing-always-mib branch November 6, 2025 21:15
@maralorn
Copy link
Copy Markdown
Member

maralorn commented Nov 8, 2025

This PR is unfortunate I think. This goes backwards for all Nix users for the few that use nom.

From my random sampling of looking on screens at nix cons a lot of users use nom, not just a few. 😆

Would it not be easier to fix nom ?

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants