refactor(libstore): pass headers into upload methods#14477
Merged
Conversation
This will make it easier to attach additional headers (e.g. storage class) on the s3 side of things and makes `Content-Encoding` less special.
github-actions
Bot
added
the
store
xokdvium
reviewed
Nov 5, 2025
lovesegfault
force-pushed
the
http-upload-headers
branch
from
a55411c to
a0d4714
Compare
Member
|
So after this change I think that is more honest because We can still keep a TODO about constant-space compression on upload, it just wouldn't be associated with |
Ericson2314
reviewed
Nov 7, 2025
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
Otherwise this looks good. I like having fewer upload methods again. This does feel better.
Ericson2314
approved these changes
Nov 7, 2025
Member
|
Actually my comment can just a follow-up cleanup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This will make it easier to attach additional headers (e.g. storage
class) on the s3 side of things and makes
Content-Encodinglessspecial.
I also got rid of the override for CompressedSource, since I don't think it was helping much.
Context
This should simplify #14464 a bit.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.