DerivationBuilderParams have reference to BasicDerivation#14490
Merged
Ericson2314 merged 1 commit intoNov 6, 2025
Conversation
Have one to that instead of one to `Derivation`. `DerivationBuilder` doesn't need `inputDrvs`, so `BasicDerivation` suffices. (In fact, it doesn't need `inputSrcs` either, but we don't yet hve a type to exclude that.)
Mic92
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Have one to that instead of one to
Derivation.DerivationBuilderdoesn't needinputDrvs, soBasicDerivationsuffices.Context
(In fact, it doesn't need
inputSrcseither, but we don't yet hve a type to exclude that.)Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.