Move GitHub input attribute validation into inputFromAttrs()#14656
Merged
Conversation
Previously inputFromAttrs() didn't do any validation. inputFromURL() now calls inputFromAttrs(), so we only need to validate in one place. Fixes #14655.
github-actions
Bot
added
the
fetching
xokdvium
approved these changes
Nov 26, 2025
Contributor
xokdvium
left a comment
xokdvium
left a comment
There was a problem hiding this comment.
Makes sense. Would be good to have a regression test for the issue since there's now unit test infra to set that up easily. Can be done separately though, this simplification is good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Previously
inputFromAttrs()didn't do any validation.inputFromURL()now callsinputFromAttrs(), so we only need to validate in one place.Fixes #14655.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.