Create proper serializer for BuildResult status#14749
Merged
Ericson2314 merged 1 commit intoJan 26, 2026
Merged
Conversation
github-actions
Bot
added
the
store
Ericson2314
force-pushed
the
build-status-serializer
branch
from
06fc951 to
49a6aa7
Compare
The casts were not safe with respect to unknown values, but these are.
Ericson2314
force-pushed
the
build-status-serializer
branch
from
49a6aa7 to
bfdd124
Compare
Ericson2314
commented
Jan 26, 2026
| auto rawStatus = readNum<uint8_t>(conn.from); | ||
|
|
||
| if (rawStatus >= std::size(buildResultStatusTable)) | ||
| throw Error("Invalid BuildResult status %d from remote", rawStatus); |
Member
Author
There was a problem hiding this comment.
If a problem arises, can make this a warning and use a default, but I rather start with this stricter logic, in hope that it is not a problem in practice.
Mic92
approved these changes
Jan 26, 2026
brittonr
pushed a commit
to brittonr/nix
that referenced
this pull request
Apr 1, 2026
…alizer Create proper serializer for BuildResult status
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The casts were not safe with respect to unknown values, but these are.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.