More std::filesystem::path#14974
Closed
Ericson2314 wants to merge 4 commits into
Closed
Conversation
github-actions
Bot
added
new-cli
Ericson2314
commented
Jan 11, 2026
Mic92
reviewed
Jan 13, 2026
| return std::find(normalized.begin(), normalized.end(), "profiles") == normalized.end() | ||
| && std::filesystem::is_symlink(profileDir); | ||
| }()) | ||
| profileDir = std::filesystem::read_symlink(profileDir); |
Member
Author
There was a problem hiding this comment.
Yeah I will convert these back, we have the wrapper functions now
Mic92
reviewed
Jan 13, 2026
| profileDir = readLink(profileDir.string()); | ||
| while ([&] { | ||
| auto normalized = profileDir.lexically_normal(); | ||
| return std::find(normalized.begin(), normalized.end(), "profiles") == normalized.end() |
Member
Author
|
Draft because #14973 should be merged first. |
Ericson2314
force-pushed
the
more-mingw-fixes
branch
6 times, most recently
from
1b9bf1f to
5d1fd3f
Compare
But the definition is still kept for downstream
Ericson2314
force-pushed
the
more-mingw-fixes
branch
from
858835e to
f717a37
Compare
Member
Author
|
We've now done all the std filesystem path (yay!) so this can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Progress on #9205
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.