More windows fixes#14984
Merged
Merged
Conversation
github-actions
Bot
added
the
store
xokdvium
force-pushed
the
more-windows-fixes
branch
from
faf67ac to
98dbb54
Compare
xokdvium
force-pushed
the
more-windows-fixes
branch
from
98dbb54 to
66fefcd
Compare
Ericson2314
approved these changes
Jan 12, 2026
brittonr
pushed a commit
to brittonr/nix
that referenced
this pull request
Apr 1, 2026
More windows fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
See individual commits.
createAnonymousTempFilenow cleans up after itselfSystemErrorhas astd::error_codefor platform-independent checking of error codes. With this change and a bit of local hackery forfile://URLs on Windows (the triple slash) I got the local binary cache store working:Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.