More NAR accessor / listing cleanup#14990
Merged
Merged
Conversation
I like the separation of concerns from NAR accessing.
Now we have less of a maze of implementation structs. Review with ``` git show --color-moved --patience --color-moved-ws=ignore-all-space ```
This makes some invariants clearer and more local.
We already have it, so let's just use it!
github-actions
Bot
added
the
store
edolstra
approved these changes
Jan 14, 2026
brittonr
pushed a commit
to brittonr/nix
that referenced
this pull request
Apr 1, 2026
More NAR accessor / listing cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Separate concerns and split file. I find it easier to read now --- don't need to absorb everything at once anymore.
Last commit is performance improvement too.
Context
The overall diff is not so bad, especially with
but it may also help to look commit-by-commit.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.