fix(libstore/filetransfer): skip Accept-Encoding header for S3 SigV4 requests#15048
Merged
Conversation
lovesegfault
force-pushed
the
fix-15019
branch
from
6481f48 to
47c2f2c
Compare
…requests Some S3-compatible services (like GCS) modify the Accept-Encoding header in transit, which breaks AWS SigV4 signature verification since curl's implementation signs all headers including Accept-Encoding. Fixes: NixOS#15019
lovesegfault
force-pushed
the
fix-15019
branch
from
47c2f2c to
fcfa1dc
Compare
edolstra
approved these changes
Jan 22, 2026
edolstra
added
the
backport 2.33-maintenance
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.33-maintenance
git worktree add -d .worktree/backport-15048-to-2.33-maintenance origin/2.33-maintenance
cd .worktree/backport-15048-to-2.33-maintenance
git switch --create backport-15048-to-2.33-maintenance
git cherry-pick -x fcfa1dc8ab37a5a5ca987a52f964c2e6cb565028 |
philiptaron
added a commit
to philiptaron/nixpkgs
that referenced
this pull request
Feb 7, 2026
## Bug fixes - Fix destruction of DerivationBuilder implementations (NixOS/nix#15072) - Don't report cancelled goals as failures (NixOS/nix#14972) - Fix `linux` build on fresh `glibc` and `gcc` (NixOS/nix#15011) ## S3 binary cache improvements - Add AWS SSO support for S3 authentication (NixOS/nix#14645) - Respect `AWS_PROFILE` environment variable (NixOS/nix#14645) - Add STS support for default profile (NixOS/nix#14645) - Skip `Accept-Encoding` header for S3 SigV4 requests (NixOS/nix#15048) - Restart source before upload retries (NixOS/nix#15047) - Route AWS CRT logs through Nix logger (NixOS/nix#15059) The glibc 2.42 build fix patch is dropped as it is now included upstream. https://github.com/NixOS/nix/releases/tag/2.33.2
13 tasks
2 tasks
brittonr
pushed a commit
to brittonr/nix
that referenced
this pull request
Apr 1, 2026
fix(libstore/filetransfer): skip Accept-Encoding header for S3 SigV4 requests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Some S3-compatible services (like GCS) modify the Accept-Encoding header
in transit, which breaks AWS SigV4 signature verification since curl's
implementation signs all headers including Accept-Encoding.
Context
Fixes: #15019
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.