libstore: split out LogFileSettings#15051
Merged
Merged
Conversation
amaanq
force-pushed
the
split-build-log-settings
branch
2 times, most recently
from
81e9142 to
1d3484e
Compare
amaanq
changed the title
LogFileSettings
amaanq
force-pushed
the
split-build-log-settings
branch
from
1d3484e to
b8e5ec9
Compare
amaanq
force-pushed
the
split-build-log-settings
branch
from
b8e5ec9 to
12aa7c7
Compare
github-actions
Bot
added
the
store
Ericson2314
reviewed
Jan 22, 2026
amaanq
force-pushed
the
split-build-log-settings
branch
2 times, most recently
from
d850f12 to
cfd262e
Compare
Ericson2314
approved these changes
Jan 22, 2026
amaanq
added a commit
to amaanq/nix
that referenced
this pull request
Jan 22, 2026
This PR follows the same approach as NixOS#15043 and the [`LogFileSettings`](NixOS#15051) extraction: - `GCSettings` struct inherits from virtual `Config` - `Settings` privately inherits from it - Accessed through `getGCSettings()`
amaanq
added a commit
to amaanq/nix
that referenced
this pull request
Jan 22, 2026
This PR follows the same approach as NixOS#15043 and the [`LogFileSettings`](NixOS#15051) extraction: - `GCSettings` struct inherits from virtual `Config` - `Settings` privately inherits from it - Accessed through `getGCSettings()` The new method on `LocalStoreConfig` anticipates on making these settings per-store. [This commit](NixOS@0b606aa) added both the autoGC and periodic wakeups.
amaanq
added a commit
to amaanq/nix
that referenced
this pull request
Jan 22, 2026
This PR follows the same approach as NixOS#15043 and the [`LogFileSettings`](NixOS#15051) extraction: - `GCSettings` struct inherits from virtual `Config` - `Settings` privately inherits from it - Accessed through `getGCSettings()` The new method on `LocalStoreConfig` anticipates on making these settings per-store. 0b606aa added both the autoGC and periodic wakeups, which is why we think they are related.
amaanq
added a commit
to amaanq/nix
that referenced
this pull request
Jan 22, 2026
This PR follows the same approach as NixOS#15043 and the [`LogFileSettings`](NixOS#15051) extraction: - `GCSettings` struct inherits from virtual `Config` - `Settings` privately inherits from it - Accessed through `getGCSettings()` The new method on `LocalStoreConfig` anticipates on making these settings per-store. 0b606aa added both the autoGC and periodic wakeups, which is why we think they are related.
amaanq
force-pushed
the
split-build-log-settings
branch
from
cfd262e to
34aed9a
Compare
github-actions
Bot
added
documentation
with-tests
amaanq
force-pushed
the
split-build-log-settings
branch
from
34aed9a to
9c2263a
Compare
auto-merge was automatically disabled
January 23, 2026 18:17
Head branch was pushed to by a user without write access
amaanq
force-pushed
the
split-build-log-settings
branch
from
9c2263a to
98178e2
Compare
Mic92
approved these changes
Jan 23, 2026
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Jan 26, 2026
This PR follows the same approach as NixOS#15043 and the extraction in NixOS#15051. The `DatabaseSettings` struct inherits from the virtual `Config` class, and `Settings` privately inherits from it.
brittonr
pushed a commit
to brittonr/nix
that referenced
this pull request
Apr 1, 2026
This PR follows the same approach as NixOS#15043 and the [`LogFileSettings`](NixOS#15051) extraction: - `GCSettings` struct inherits from virtual `Config` - `Settings` privately inherits from it - Accessed through `getGCSettings()` The new method on `LocalStoreConfig` anticipates on making these settings per-store. afe1e5c added both the autoGC and periodic wakeups, which is why we think they are related.
brittonr
pushed a commit
to brittonr/nix
that referenced
this pull request
Apr 1, 2026
libstore: split out `LogFileSettings`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR progresses on #5638
The log file settings (
nixLogDir,keepLog,compressLog) are logically related but scattered in the largeSettingsclass.Context
This follows the same pattern as #15043 in that we:
LogFileSettingsstruct that inherits fromvirtual ConfigSettingsprivately inherit from itusingdeclarations to preserve the existing APIgetLogFileSettings()getter for explicit dependency injectionAdd 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.