Cleanup stat usage#15077
Merged
Merged
Conversation
github-actions
Bot
added
new-cli
Ericson2314
force-pushed
the
stat-wrapper
branch
from
1f32699 to
622cfc8
Compare
xokdvium
reviewed
Jan 26, 2026
Ericson2314
force-pushed
the
stat-wrapper
branch
from
622cfc8 to
4d65504
Compare
Use wrappers to make error handling easier. On Windows we are using proper 64-bit time and size info. We still have the problem of no `lstat` on Windows, but this will be dealt with in future PRs.
Ericson2314
force-pushed
the
stat-wrapper
branch
from
4d65504 to
a13de50
Compare
xokdvium
approved these changes
Jan 26, 2026
brittonr
pushed a commit
to brittonr/nix
that referenced
this pull request
Apr 1, 2026
Cleanup stat usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Use wrappers to make error handling easier.
Context
On Windows we are using proper 64-bit time and size info.
We still have the problem of no
lstaton Windows, but this will be dealt with in future PRs.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.