std::filesystem::path in some Settings fields#15089
Merged
Merged
Conversation
github-actions
Bot
added
new-cli
Ericson2314
force-pushed
the
sfp-global-settings
branch
2 times, most recently
from
ee7d24c to
956b6d8
Compare
Ericson2314
force-pushed
the
sfp-global-settings
branch
2 times, most recently
from
9e92fd4 to
f091172
Compare
roberth
approved these changes
Feb 9, 2026
| @@ -10,12 +10,12 @@ namespace nix { | |||
|
|
|||
| Path LocalFSStoreConfig::getDefaultStateDir() | |||
Ericson2314
force-pushed
the
sfp-global-settings
branch
from
f091172 to
6a43173
Compare
xokdvium
approved these changes
Feb 10, 2026
Ericson2314
force-pushed
the
sfp-global-settings
branch
from
6a43173 to
ef65913
Compare
|
Hey! I was fixing my setup to work on this issue 😢 |
Member
Author
|
Sorry! I ended up needing it sooner, and when @amaanq (my coworker) looked a it, it always was simpler than I thought. #15022 (comment) see this for another idea, and I promise I won't steal it from you, as I am not doing anything that depends upon it. |
brittonr
pushed a commit
to brittonr/nix
that referenced
this pull request
Apr 1, 2026
`std::filesystem::path` in some `Settings` fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Progress on #9205
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.