tests/functional: fix nix-shell fixed-output derivation test#15098
Merged
Conversation
The test was checking for `$stdenv` but the `fixed` derivation doesn't actually have stdenv, it just has `FOO`. I've updated it to check the value of `FOO` instead.
github-actions
Bot
added
the
with-tests
Ericson2314
approved these changes
Jan 27, 2026
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
This looks good to me. Just waiting for confirm that the NixOS test running the functional tests does in fact build now.
Member
Author
|
Yep, running the NixOS functional tests passed (via |
brittonr
pushed a commit
to brittonr/nix
that referenced
this pull request
Apr 1, 2026
tests/functional: fix nix-shell fixed-output derivation test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test was checking for
$stdenvbut thefixedderivation doesn't actually have stdenv, it just hasFOO. I've updated it to check the value ofFOOinstead.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.