libcmd: add new StoreConfigCommand class#15145
Merged
Merged
Conversation
Ericson2314
reviewed
Feb 4, 2026
artemist
force-pushed
the
storeconfigcommand
branch
from
5f5f536 to
98267d2
Compare
artemist
force-pushed
the
storeconfigcommand
branch
2 times, most recently
from
7e45c77 to
45977e8
Compare
Ericson2314
changed the title
StoreConfigCommand class
Ericson2314
reviewed
Feb 4, 2026
Useful for commands that need a `StoreConfig` but do not want to open the store, as a `StoreCommand` would do. At the same time, make copy commands more clear by making store choice for `updateProfile` explicit and removing the unused `getDstStore` function in `StoreCommand`. This was a layer violation, as `StoreCommand` does not have a concept of a source/destination store distinction.
artemist
force-pushed
the
storeconfigcommand
branch
from
45977e8 to
124605d
Compare
Ericson2314
approved these changes
Feb 4, 2026
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
Very excited to see that tech debt gone!
brittonr
pushed a commit
to brittonr/nix
that referenced
this pull request
Apr 1, 2026
libcmd: add new `StoreConfigCommand` class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I needed this change in #15143, but it is not related to any of the features in that PR. it may also be useful for other future commands that want store configuration without opening the store, as a StoreCommand would do.
At the same time, make copy commands more clear by making store choice
for
updateProfileexplicit and removing the unusedgetDstStorefunctionin
StoreCommand. This was a layer violation, asStoreCommanddoesnot have a concept of a source/destination store distinction.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.