libstore: make substitution use the per-store getReadOnly method#15218
Merged
Conversation
github-actions
Bot
added
the
store
amaanq
changed the title
amaanq
changed the title
getReadOnly method
Ericson2314
approved these changes
Feb 13, 2026
This commit introduces a `getReadOnly` method on the store config that returns if the current store is read only or not. This is then used in subtitution, so we fail gracefully with a nice error message if only the individual store is read-only. As a bonus, it gets us one step closer to getting rid of the global because we can use the per-store method instead. Progress on NixOS#5638
amaanq
force-pushed
the
read-only-per-store
branch
from
b18bcaa to
9ac91e3
Compare
brittonr
pushed a commit
to brittonr/nix
that referenced
this pull request
Apr 1, 2026
libstore: make substitution use the per-store `getReadOnly` method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This commit introduces a
getReadOnlymethod on the store config that returns if the current store is read only or not. This is then used in subtitution, so we fail gracefully with a nice error message if only the individual store is read-only.As a bonus, it gets us one step closer to getting rid of the global because we can use the per-store method instead.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.