libutil-tests: Fix crash on Windows#15235
Merged
Merged
Conversation
Ericson2314
force-pushed
the
os-environ
branch
from
2e4b948 to
dbf32ae
Compare
github-actions
Bot
added
new-cli
libutil tests were crashing on Windows due to issues finding `environ`. Replace process creation of `getEnv` with a new `getEnvOs` function that uses native windows APIs. Also convert a bunch of `RunOptions` fields to use `OsString` to better reflect the underlying interfaces. Co-authored-by: John Ericson <John.Ericson@Obsidian.Systems>
Co-authored-by: John Ericson <John.Ericson@Obsidian.Systems>
Ericson2314
force-pushed
the
os-environ
branch
from
dbf32ae to
36d0e95
Compare
Ericson2314
approved these changes
Feb 15, 2026
brittonr
pushed a commit
to brittonr/nix
that referenced
this pull request
Apr 1, 2026
libutil-tests: Fix crash on Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
libutil tests were crashing on Windows due to issues finding
environ. Replace process creation ofgetEnvwith a newgetEnvOsfunction that uses native windows APIs.Context
We already had a
getEnvOsfunction to return a single variable, but none that would return all keys.Using OsString environment variables reduces round-trips.
The old code also did not properly handle overriding environment variables, it would place them in the map twice.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.