libflake: fix assertion crash when malformed URL falls through to path scheme#15253
Merged
Merged
Conversation
…h scheme When a URL like `github:nixos/nixpkgs/nixpkgs.git?ref=<hash>` (using `ref` instead of `rev`) failed the github input scheme, it fell through to `parsePathFlakeRefWithFragment` which constructed a `path:` `ParsedURL` with an empty authority but a relative path. This violated RFC 3986 section 3.3 (authority present requires path starting with `/`), causing an assertion failure in `renderAuthorityAndPath` when `PathInputScheme` tried to format the URL for an error message. This commit only sets the authority on absolute paths. Relative paths get `std::nullopt` for authority, which is the correct representation per the URL spec. Fixes NixOS#15196. Fixes NixOS#14830.
amaanq
force-pushed
the
fix-url-assertion
branch
from
abae6b7 to
a32cd16
Compare
xokdvium
approved these changes
Feb 16, 2026
brittonr
pushed a commit
to brittonr/nix
that referenced
this pull request
Apr 1, 2026
libflake: fix assertion crash when malformed URL falls through to path scheme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When a URL like
github:nixos/nixpkgs/nixpkgs.git?ref=<hash>(usingrefinstead ofrev) failed the github input scheme, it fell through toparsePathFlakeRefWithFragmentwhich constructed apath:ParsedURLwith an empty authority but a relative path. This violated RFC 3986 section 3.3 (authority present requires path starting with/), causing an assertion failure inrenderAuthorityAndPathwhenPathInputSchemetried to format the URL for an error message.This commit only sets the authority on absolute paths. Relative paths get
std::nulloptfor authority, which is the correct representation per the URL spec.Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.