tests: add writeFull interrupt-handling regression test#15321
Merged
Conversation
amaanq
changed the title
writeFull interrupt-handling regression test
This commit verifies that `writeFull` with `allowInterrupts=false` completes successfully when the interrupt flag is set. This prevents regressions like the one fixed by NixOS#15255 where `write()` called `checkInterrupt()` unconditionally.
amaanq
force-pushed
the
writefull-interrupt-test
branch
from
30e1d01 to
6cddf03
Compare
Contributor
|
PR link is wrong? |
Member
Author
Updated, thank you! |
xokdvium
approved these changes
Feb 23, 2026
brittonr
pushed a commit
to brittonr/nix
that referenced
this pull request
Apr 1, 2026
…pt-test tests: add `writeFull` interrupt-handling regression test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This commit verifies that
writeFullwithallowInterrupts=falsecompletes successfully when the interrupt flag is set. This prevents regressions like the one fixed by #15319 wherewrite()calledcheckInterrupt()unconditionally.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.