Use per-platform signal for internal interrupts instead of SIGUSR1#15414
Merged
Conversation
Ericson2314
approved these changes
Mar 6, 2026
Member
|
Thanks for splitting! |
xokdvium
reviewed
Mar 6, 2026
Ericson2314
reviewed
Mar 6, 2026
FreeBSD bdwgc uses SIGUSR1 internally for its runtime. Use a different signal. See [1] for documentation and the suggestion to use SIGTSTP on FreeBSD. [1] https://github.com/bdwgc/bdwgc/blob/af374f921837af641f2f61698ab90767befd8996/include/private/gc_priv.h#L4557
Contributor
Author
|
@Ericson2314 if you smash that retry button on CI it should probably work :) |
Member
|
Smashed! |
Contributor
Author
|
It seems to be failing because CI references a sourcehut url which has recently been put behind an automation deterrant. |
Contributor
|
Looks like the sources are gone there. Oh well... disabled those for now |
Contributor
|
I guess one question I have is: why SIGTSTP? Is SIGUSR2 not available as well? |
Contributor
|
Ah sorry, missed the explanation in the commit message there. All good! |
brittonr
pushed a commit
to brittonr/nix
that referenced
this pull request
Apr 1, 2026
Use per-platform signal for internal interrupts instead of SIGUSR1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit message. Split out from #9968