installer: improve existing rc backup nag#5524
Merged
edolstra merged 1 commit intoNov 10, 2021
Merged
Conversation
abathur
commented
Nov 9, 2021
| for profile_target in "${PROFILE_TARGETS[@]}"; do | ||
| # TODO: I think it would be good to accumulate a list of all | ||
| # of the copies so that people don't hit this 2 or 3x in | ||
| # a row for different files. |
Member
Author
There was a problem hiding this comment.
I would, to be frank, like it to work as commented, and not as coded.
I didn't want to let that pass completely undocumented--but I'm chasing other white whales at the moment and do not have the emotional/intellectual energy to make this happen without an installer test suite that ensures the important bits stay nailed down.
5f24ce9 to
d223050
Compare
Member
Author
I've force-pushed addressing feedback per 3 :) |
edolstra
reviewed
Nov 9, 2021
toonn
reviewed
Nov 9, 2021
d223050 to
f7859ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking into #5521 I noticed that the installer instructions don't really connect the dots about what the user is expected to do.
This is a tentative rephrase, but I also realize that this kind of thing may well be informed by history--that we're intentionally leaving out steps so that the kinds of people confused by this will ask for help instead of screwing up their systems and trashing us on social.I think GC would've cautioned if this were the case.Objections? @toonn @grahamc @domenkozar
for reference, should look something like: