treewide: rename fetchPypi -> fetchFromPyPI#119896
treewide: rename fetchPypi -> fetchFromPyPI#119896Synthetica9 wants to merge 1 commit intoNixOS:masterfrom
Conversation
This rename does two things:
1. Brings the capitization in line with the preferred capitization:
PyPI is short for "Python Package Index" and references itself with
this capitalized name.
2. Adds "From". This is for consistency with other fetchers, which use
from when fetching from a central or default repository:
* fetchFromGitHub
* fetchFromGitLab
* fetchFromSourcehut
* etc.
A fetcher without "From" is used for fetchers without a central or
default repository:
* fetchurl
* fetchpatch
* fetchgit
* fetchzip
* etc.
Since PyPI has a central repository, it should use the first pattern.
|
I marked this as stale due to inactivity. → More info |
|
Can we redo this in a sprintable? |
|
I don't know how sprintable this is; it should just be merged in one shot I think and it's a fairly simple find-and-replace |
|
I am thinking in something like this:
After this PR be merged, the sprint can begin! The sprint can be made in small steps, after all ripgrep returns 6400+ hits After the sprint, move the alias to |
|
If we're going to make a change I think it is preferable to have it instead generate an url that needs to explicitly be used with a fetcher (fetchurl), the reason being this function does not actually implement a fetcher, only a routine for computing an url. |
You are suggesting something like this below? src = fetchurl {
url = pypiurl pname version;
hash = "...";
}I think it is not a useful distinction.
|
Motivation for this change
This rename does two things:
PyPI is short for "Python Package Index" and references itself with
this capitalized name.
from when fetching from a central or default repository:
A fetcher without "From" is used for fetchers without a central or
default repository:
Since PyPI has a central repository, it should use the first pattern.
NB. This is intended to be a 0-rebuild change, so while it affects a large amount of files it should not cause a mass rebuild.
TODO:
fetchPypiThings done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)