Skip to content

agdaPackages.agda-prelude: compat-2.6.1 -> compat-2.6.2 #140760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SuperSandro2000 merged 1 commit into from
Oct 6, 2021
Merged

agdaPackages.agda-prelude: compat-2.6.1 -> compat-2.6.2 #140760

SuperSandro2000 merged 1 commit into from
Oct 6, 2021

Conversation

@turion
Copy link
Contributor

@turion turion commented Oct 6, 2021

Motivation for this change

See #130424 (comment) when it was marked unbroken, and UlfNorell/agda-prelude#86 for the fix.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

CC @mudri @alexarice

@github-actions github-actions bot added the 6.topic: agda A dependently typed programming language / interactive theorem prover label Oct 6, 2021
@turion turion force-pushed the dev_bump_agda_prelude branch from 256a3c0 to 1929ba1 Compare October 6, 2021 13:21
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 6, 2021
@turion
Copy link
Contributor Author

turion commented Oct 6, 2021

@ofborg build agdaPackages.agda-prelude.passthru.tests

@turion
Copy link
Contributor Author

turion commented Oct 6, 2021

@ofborg build agdaPackages.agda-prelude

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Oct 6, 2021
@ofborg ofborg bot requested review from alexarice and laMudri October 6, 2021 13:34
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 6, 2021
laMudri
laMudri approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@laMudri laMudri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it type-checks, ship it.

@SuperSandro2000 SuperSandro2000 merged commit 1d88d6f into NixOS:master Oct 6, 2021
@turion turion deleted the dev_bump_agda_prelude branch October 7, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexarice alexarice Awaiting requested review from alexarice

1 more reviewer

@laMudri laMudri laMudri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: agda A dependently typed programming language / interactive theorem prover 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@turion @laMudri @SuperSandro2000