Revert "libeatmydata: patch out LFS64 usage" #311286
Merged
+0
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c7f51f0. This broke 32-bit Glibc builds. I've submitted a revised patch upstream, but in the meantime, there's no point keeping this around, since we didn't do the musl upgrade yet. Link: NixOS#292654 (comment) Link: stewartsmith/libeatmydata#36
misuzu
approved these changes
May 13, 2024
Contributor
misuzu
left a comment
misuzu
left a comment
There was a problem hiding this comment.
This fixes my issues, thank you!
ofborg
bot
added
10.rebuild-darwin: 1-10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This reverts commit c7f51f0.
This broke 32-bit Glibc builds. I've submitted a revised patch upstream, but in the meantime, there's no point keeping this around, since we didn't do the musl upgrade yet.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.