-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
rpPPPoE: 3.12 -> 4.0 and build kernel mode plugin #349480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
FliegendeWurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to squash the last two commits. LGTM otherwise
The old rpPPPoE package from Roaring Penguin is no longer maintained and the download link is also inaccessible. So I switch the upstream to https://github.com/dfskoll/rp-pppoe. Also, according to the discussions in https://github.com/dfskoll/rp-pppoe/issues/32, it is strongly recommended to use rpPPPoE in the kernel mode, as it is more stable and performant than in the user mode. So I enable the compilation of the kernel mode plugin `rp-pppoe.so`. It will be available at `/run/current-system/sw/lib/rp-pppoe.so`.
Member
Author
|
@FliegendeWurst Thanks for your reviews! I've squashed the last two commits. |
FliegendeWurst
approved these changes
Nov 16, 2024
misuzu
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
8.has: maintainer-list (update)
This PR changes `maintainers/maintainer-list.nix`
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin.
10.rebuild-linux: 1-10
This PR causes between 1 and 10 packages to rebuild on Linux.
10.rebuild-linux: 1
This PR causes 1 package to rebuild on Linux.
11.by: package-maintainer
This PR was created by a maintainer of all the package it changes.
12.approvals: 1
This PR was reviewed and approved by one person.
12.first-time contribution
This PR is the author's first one; please be gentle!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old rpPPPoE package from Roaring Penguin is no longer maintained and the download link is also inaccessible. So I switch the upstream to https://github.com/dfskoll/rp-pppoe. Release note: https://github.com/dfskoll/rp-pppoe/blob/master/doc/CHANGES.
Also, according to the discussions in https://github.com/dfskoll/rp-pppoe/issues/32, it is strongly recommended to use rpPPPoE in the kernel mode, as it is more stable and performant than in the user mode. So I enable the compilation of the kernel mode plugin
rp-pppoe.so. It will be available at/run/current-system/sw/lib/rp-pppoe.so.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Working example
It functions as expected with the following configuration:
Add a 👍 reaction to pull requests you find important.