Skip to content

Conversation

@ShadowRZ
Copy link
Member

https://github.com/netlify/cli/blob/v17.37.1/CHANGELOG.md

Turned out migrating to buildNpmPackage was much easier than I thought.

Closes #336530

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from winterqt October 24, 2024 09:25
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 24, 2024
@ShadowRZ ShadowRZ force-pushed the shadowrz/netlify-cli-phase-out-node2nix branch from 9622f8e to ea6d4a9 Compare November 8, 2024 12:26
@ShadowRZ ShadowRZ force-pushed the shadowrz/netlify-cli-phase-out-node2nix branch from ea6d4a9 to 4c0227b Compare November 8, 2024 12:27
@ShadowRZ
Copy link
Member Author

ShadowRZ commented Nov 8, 2024

Fixed meta infomations.

@ofborg ofborg bot requested a review from roberth November 8, 2024 14:39
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!
I've tried before, without success: #336530

Tested:

  • ✔️ tests.test attribute
    • ✔️ x86_64-linux
    • ❌ aarch64-darwin
      • ✔️ run netlify dev by hand
  • ✔️ push a preview deployment

I haven't managed to debug the darwin test failure, so a manual test will have to do, because this package is in dire need of an update.

@roberth roberth merged commit f8d0c64 into NixOS:master Nov 14, 2024
4 of 5 checks passed
@roberth
Copy link
Member

roberth commented Nov 14, 2024

Thank you @ShadowRZ!

@roberth
Copy link
Member

roberth commented Dec 2, 2024

This must have been shortly after branch-off.
The version in 24.11 is still horribly ridiculously old, so I'd like to make somewhat of an exception and backport this, as the current version in 24.11 is definitely unsupported.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants