Skip to content

caf: apply formatting #352592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Aleksanaa merged 1 commit into from
Nov 29, 2024
Merged

caf: apply formatting #352592

Aleksanaa merged 1 commit into from
Nov 29, 2024

Conversation

@tobim
Copy link
Contributor

@tobim tobim commented Oct 31, 2024

Only a small maintenance update, should not cause any rebuilds.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 31, 2024
@Pandapip1 Pandapip1 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 9, 2024
@Pandapip1
Copy link
Member

Pandapip1 commented Nov 9, 2024

Merge conflict due to #354531.

@wegank wegank force-pushed the pkgs/by-name/ca/caf branch from 8260d11 to 9af38b4 Compare November 10, 2024 03:31
@wegank wegank removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 10, 2024
@Aleksanaa Aleksanaa changed the title caf: move to by-name, reformat caf: apply formatting Nov 10, 2024
@Pandapip1 Pandapip1 added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 29, 2024
@Aleksanaa Aleksanaa merged commit a68d0d6 into NixOS:master Nov 29, 2024
6 checks passed
@tobim tobim deleted the pkgs/by-name/ca/caf branch November 29, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Pandapip1 Pandapip1 Pandapip1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tobim @Pandapip1 @wegank @Aleksanaa