Skip to content

postgresql_17: fix build #354571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ma27 merged 1 commit into from
Nov 9, 2024
Merged

postgresql_17: fix build #354571

Ma27 merged 1 commit into from
Nov 9, 2024
+6 −0

Conversation

@Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 8, 2024 •
edited
Loading

Closes #354497

See https://www.postgresql.org/message-id/ba8e1bc0-8a99-45b7-8397-3f2e94415e03%40suse.de for context.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Ma27 Ma27 requested review from a team and wolfgangwalther and removed request for wolfgangwalther November 8, 2024 19:37
@Ma27
Copy link
Member Author

Ma27 commented Nov 8, 2024

Force of habit, we have a team now 🙃

wolfgangwalther
wolfgangwalther approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 8, 2024
@ofborg ofborg bot requested review from globin, ivan and wolfgangwalther November 9, 2024 01:10
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Nov 9, 2024
@Ma27 Ma27 merged commit 8091ea3 into NixOS:master Nov 9, 2024
4 of 5 checks passed
@Ma27 Ma27 deleted the fix-postgresql-17 branch November 9, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@globin globin Awaiting requested review from globin

@wolfgangwalther wolfgangwalther Awaiting requested review from wolfgangwalther

@ivan ivan Awaiting requested review from ivan

Assignees

No one assigned

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure: postgresql_17

3 participants

@Ma27 @wolfgangwalther @wegank