audacity: use default MacOS SDK

[sarahec]

Removed unneeded reference to apple-sdk_11 in BuildInputs

See also #352129

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[sarahec]

Yes, it's a trivial change. I'm testing the waters before migrating other packages.

[wegank]

The default SDK on x86_64-darwin being apple-sdk_10_12, would these lines then be needed again?

nixpkgs/pkgs/by-name/au/audacity/package.nix

Lines 84 to 89 in d7f8e5b

	+
	lib.optionalString
	(stdenv.hostPlatform.isDarwin && lib.versionOlder stdenv.hostPlatform.darwinMinVersion "11.0")
	''
	sed -z -i "s/NSAppearanceName.*systemAppearance//" src/AudacityApp.mm
	'';

[sarahec]

Thanks for spotting that! The default hasn't been pushed forward yet. I'm going to withdraw this to avoid a possible regression.