Closed
Conversation
this includes qemu-aarch64 support
Member
|
see also #36232 |
dezgeg
reviewed
Mar 5, 2018
| filesToInstall = ["u-boot.bin"]; | ||
| }; | ||
|
|
||
| ubootQemuArm_64bit = buildUBoot rec { |
Contributor
There was a problem hiding this comment.
This could be ubootQemuAarch64, in Nixpkgs naming 'Arm' always stands for the 32-bit one.
Contributor
Thanks for the fix, I will squash that in my U-Boot patch branch for 2018.03. As the 2018.03 upstream release is only a week away, let's wait for that, then have #36232 adjusted for 2018.03, then finally the |
Contributor
|
U-Boot 2018.03 and ubootQemuAarch64are now in master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this includes qemu-aarch64 support
Motivation for this change
I needed an updated u-boot for running my rpi3 sdcard with qemu. I figured I'd push it upstream right away.
Whether we can merge this as an
-rcor not, I also wanted to document the patch I updated: It's based on dezgeg/u-boot@pythonpath-2018-03, but also accounts for u-boot/u-boot@15b97f5#diff-44b7a4b99d947fe1c4a313c4d890d8b6R384cc @dezgeg does this look right to you?
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)