Skip to content

u-boot: 2017.11 -> v2018.03-rc3#36340

Closed
bendlas wants to merge 1 commit intoNixOS:masterfrom
bendlas:update-u-boot
Closed

u-boot: 2017.11 -> v2018.03-rc3#36340
bendlas wants to merge 1 commit intoNixOS:masterfrom
bendlas:update-u-boot

Conversation

@bendlas
Copy link
Copy Markdown
Contributor

@bendlas bendlas commented Mar 5, 2018

this includes qemu-aarch64 support

Motivation for this change

I needed an updated u-boot for running my rpi3 sdcard with qemu. I figured I'd push it upstream right away.

Whether we can merge this as an -rc or not, I also wanted to document the patch I updated: It's based on dezgeg/u-boot@pythonpath-2018-03, but also accounts for u-boot/u-boot@15b97f5#diff-44b7a4b99d947fe1c4a313c4d890d8b6R384

cc @dezgeg does this look right to you?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

this includes qemu-aarch64 support
@bendlas bendlas requested a review from dezgeg March 5, 2018 13:00
@bendlas bendlas added 9.needs: community feedback This needs feedback from more community members. 0.kind: enhancement Add something new or improve an existing system. 2.status: work-in-progress 8.has: package (update) This PR updates a package to a newer version labels Mar 5, 2018
@bendlas bendlas self-assigned this Mar 5, 2018
@bendlas bendlas added the 8.has: package (new) This PR adds a new package label Mar 5, 2018
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 5, 2018
@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Mar 5, 2018

see also #36232

filesToInstall = ["u-boot.bin"];
};

ubootQemuArm_64bit = buildUBoot rec {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be ubootQemuAarch64, in Nixpkgs naming 'Arm' always stands for the 32-bit one.

@dezgeg
Copy link
Copy Markdown
Contributor

dezgeg commented Mar 5, 2018

I also wanted to document the patch I updated: It's based on dezgeg/u-boot@pythonp, but also accounts for u-boot/u-boot@15b97f5#diff-44b7a4b99d947fe1c4a313c4d890d8b6R384

Thanks for the fix, I will squash that in my U-Boot patch branch for 2018.03.

As the 2018.03 upstream release is only a week away, let's wait for that, then have #36232 adjusted for 2018.03, then finally the ubootQemuAarch64 change.

@dezgeg
Copy link
Copy Markdown
Contributor

dezgeg commented Mar 18, 2018

U-Boot 2018.03 and ubootQemuAarch64are now in master.

@dezgeg dezgeg closed this Mar 18, 2018
@bendlas bendlas deleted the update-u-boot branch October 22, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: enhancement Add something new or improve an existing system. 8.has: package (new) This PR adds a new package 8.has: package (update) This PR updates a package to a newer version 9.needs: community feedback This needs feedback from more community members. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants