ripe-atlas-tools: fix build #404607
Merged
ripe-atlas-tools: fix build #404607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erethon
added
the
0.kind: ZHF Fixes
github-actions
bot
added
10.rebuild-darwin: 1
Contributor
Author
|
Member
|
It works, it cost me 30 credits :) |
Contributor
|
Sigmanificient
approved these changes
May 7, 2025
risicle
approved these changes
May 7, 2025
Contributor
risicle
left a comment
risicle
left a comment
There was a problem hiding this comment.
nixpkgs-review happy, macos 12 x86_64 & nixos x86_64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the build for
ripe-atlas-toolsby disabling a specific test. The test breaks with Python >= 3.12 due to changes made in the argparse module. The binaries are working as expected, the test is just expecting a specific string to be found that isn't there with the new argparse changes.Hydra logs: https://hydra.nixos.org/build/295070698/nixlog/2
ZHF: #403336
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.