aws-c-common: Mark big-endian platforms as unsupported#425407
Merged
roberth merged 2 commits intoJul 15, 2025
Conversation
nix-owners
Bot
requested review from
Ericson2314,
Mic92,
RaitoBezarius,
edolstra,
roberth,
tomberek and
xokdvium
nixpkgs-ci
Bot
added
10.rebuild-darwin: 0
OPNA2608
force-pushed
the
fix/aws-c-common-no-bigendian-support
branch
from
b8e0731 to
c7801e4
Compare
roberth
approved these changes
Jul 15, 2025
| lib.meta.availableOn stdenv.hostPlatform aws-c-common | ||
| && !enableStatic | ||
| && (stdenv.hostPlatform.isLinux || stdenv.hostPlatform.isDarwin), | ||
| aws-c-common, |
Member
There was a problem hiding this comment.
This aws-c-common is only here to support the withAWS default. That's ok.
Member
|
Thank you |
This was referenced Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
awslabs/aws-c-common#1175
And only enable
withAWSin the Nix builds whenaws-c-commonis available (this doesn't propagate through dependencies, soaws-sdk-cppis available according tolib.meta.availableOn).Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.