-
-
Notifications
You must be signed in to change notification settings - Fork 17.6k
collada-dom: fix build against CMake >= 3.10 #449740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Since upstream is controlled by @nim65s, we can probably fix this in the CMake list itself. |
I don't have anything against this. Until then, this pr is still useful and can be reverted at the next package update. |
Yes, I'm running a build and will merge if OpenMW compiles successfully. |
|
|
Looks like |
SigmaSquadron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
openscenegraph builds correctly, ois needs more work in #449741.
|
On it |
|
Btw, I did not notice that, because the package I use with collada-dom is currently broken because of #437521 |
|
OK for #449818 :) |
See #445447
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.