Skip to content

libsForQt5.full: drop #452708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
K900 merged 1 commit into from
Oct 21, 2025
Merged

libsForQt5.full: drop #452708

K900 merged 1 commit into from
Oct 21, 2025

Conversation

@nim65s
Copy link
Contributor

@nim65s nim65s commented Oct 16, 2025

follows #435067

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 18, 2025
@K900
Copy link
Contributor

K900 commented Oct 18, 2025

What do you have that uses that alias? We should really delete it tbh.

@nim65s
Copy link
Contributor Author

nim65s commented Oct 18, 2025

I use that in devShells to build things that need Qt, when I'm not sure which Qt parts do I need or not.
In other words, I've just been lazy. Let's drop it instead.

@nim65s nim65s changed the title libsForQt5.full: remove insecure qtwebengine libsForQt5.full: drop Oct 18, 2025
@K900
Copy link
Contributor

K900 commented Oct 19, 2025

Needs to be conditional on allowAliases, I guess.

@mdaniels5757 mdaniels5757 added the 8.has: clean-up This PR removes packages or removes other cruft label Oct 20, 2025
@nim65s nim65s force-pushed the qt5full branch 2 times, most recently from 64dd5c0 to d9f7e80 Compare October 20, 2025 19:49
@nim65s
libsForQt5.full: drop
cc72bd2 
It was broken after qtwebengine (and qtwebview) got tagged
insecure in NixOS#435067
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 20, 2025
@K900 K900 added this pull request to the merge queue Oct 21, 2025
Merged via the queue into NixOS:master with commit f2c4a91 Oct 21, 2025
28 of 32 checks passed
@nim65s nim65s deleted the qt5full branch October 21, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

@K900 K900 Awaiting requested review from K900

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@NickCao NickCao Awaiting requested review from NickCao

Assignees

No one assigned

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nim65s @K900 @mdaniels5757