Skip to content

nix: drop the recent patch on darwin, fixing build#469207

Merged
vcunat merged 1 commit into
NixOS:masterfrom
vcunat:p/nix-darwin-fixup
Dec 9, 2025
Merged

nix: drop the recent patch on darwin, fixing build#469207
vcunat merged 1 commit into
NixOS:masterfrom
vcunat:p/nix-darwin-fixup

Conversation

@vcunat
Copy link
Copy Markdown
Member

@vcunat vcunat commented Dec 9, 2025

https://hydra.nixos.org/build/316056678

Things done


Add a 👍 reaction to pull requests you find important.

@vcunat vcunat added the 1.severity: channel blocker Blocks a channel label Dec 9, 2025
@ofborg ofborg Bot added the 6.topic: darwin Running or building packages on Darwin label Dec 9, 2025
@vcunat
Copy link
Copy Markdown
Member Author

vcunat commented Dec 9, 2025

It's nice that adding .appendPatches [] doesn't change the derivation.

@vcunat
Copy link
Copy Markdown
Member Author

vcunat commented Dec 9, 2025

I honestly don't like to spend much energy on *-darwin, but having nix build on Hydra is quite important.

@vcunat
Copy link
Copy Markdown
Member Author

vcunat commented Dec 9, 2025

Oh yeah, this can be seen as a partial revert of PR #468208

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 9, 2025
@vcunat vcunat added this pull request to the merge queue Dec 9, 2025
Merged via the queue into NixOS:master with commit 339f145 Dec 9, 2025
29 of 33 checks passed
@vcunat vcunat deleted the p/nix-darwin-fixup branch December 9, 2025 07:10
@vcunat
Copy link
Copy Markdown
Member Author

vcunat commented Dec 9, 2025

Added also into the backport PR #468221

@dramforever
Copy link
Copy Markdown
Contributor

I opened NixOS/nix#14751 and hopefully someone will do something about it for 2.31.3. I think we'll leave it at this for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: channel blocker Blocks a channel 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants