Skip to content

cnijfilter2: Fix build error with GCC 15 #476341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stefanboca wants to merge 1 commit into from
Closed

cnijfilter2: Fix build error with GCC 15 #476341

stefanboca wants to merge 1 commit into from

Conversation

@stefanboca
Copy link
Contributor

@stefanboca stefanboca commented Jan 2, 2026

Closes #476330. Related to #475479.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jan 2, 2026
@stefanboca stefanboca force-pushed the sb/push-mpzkmnummtkw branch 2 times, most recently from 2405749 to 8680cd0 Compare January 2, 2026 20:56
rhoriguchi
rhoriguchi approved these changes Jan 2, 2026
View reviewed changes
Copy link
Contributor

@rhoriguchi rhoriguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes build on x86_64-linux

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jan 2, 2026
@stefanboca stefanboca force-pushed the sb/push-mpzkmnummtkw branch 3 times, most recently from f75a826 to d4a87af Compare January 2, 2026 22:42
@stefanboca
Copy link
Contributor Author

stefanboca commented Jan 2, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 476341
Commit: d4a87afa6242bb4c705a900b5e506b3e241a6bf6

x86_64-linux

✅ 1 package built:
  • cnijfilter2

@stefanboca stefanboca force-pushed the sb/push-mpzkmnummtkw branch from d4a87af to 9107a9f Compare January 2, 2026 23:26
@stefanboca stefanboca force-pushed the sb/push-mpzkmnummtkw branch from 9107a9f to 9f75f6e Compare January 3, 2026 00:24
darth10 added a commit to darth10/nix-dotfiles that referenced this pull request Jan 4, 2026
@darth10
Update flake 20260104
6784feb 
- Disabled nodejs
- Disabled cnij2filter printing driver. Fixed in
  NixOS/nixpkgs#476341
Prince213
Prince213 requested changes Jan 5, 2026
View reviewed changes
Copy link
Member

@Prince213 Prince213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd want to fix the package if possible and use the flag as a last resort as described in #475479.

@Prince213
Copy link
Member

Prince213 commented Jan 5, 2026

#477193

@Prince213 Prince213 closed this Jan 5, 2026
@stefanboca stefanboca deleted the sb/push-mpzkmnummtkw branch January 5, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Prince213 Prince213 Prince213 requested changes

+1 more reviewer

@rhoriguchi rhoriguchi rhoriguchi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure: cnijfilter2

3 participants

@stefanboca @Prince213 @rhoriguchi