Skip to content

dfu-programmer: 0.7.2 -> 1.1.0 #476376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SuperSandro2000 merged 2 commits into from
Jan 4, 2026
Merged

dfu-programmer: 0.7.2 -> 1.1.0 #476376

SuperSandro2000 merged 2 commits into from
Jan 4, 2026
+41 −13

Conversation

@mbinns
Copy link
Contributor

@mbinns mbinns commented Jan 2, 2026

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jan 2, 2026
@cybardev
Copy link
Contributor

cybardev commented Jan 2, 2026 •
edited
Loading

  1. format using nixfmt
  2. two commits: add maintainer, then the actual change
  3. add me as co-maintainer. i'll handle the Darwin side

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Jan 2, 2026
@mbinns mbinns force-pushed the update-dfu-programmer branch from 1adfcf8 to 64b0084 Compare January 2, 2026 21:48
cybardev
cybardev reviewed Jan 2, 2026
View reviewed changes
cybardev
cybardev reviewed Jan 2, 2026
View reviewed changes
pkgs/by-name/df/dfu-programmer/package.nix Outdated
};

configureFlags = [ "--disable-libusb_1_0" ];

Copy link
Contributor

@cybardev cybardev Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove one empty line

cybardev
cybardev suggested changes Jan 2, 2026
View reviewed changes
Copy link
Contributor

@cybardev cybardev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor changes

cybardev
cybardev reviewed Jan 2, 2026
View reviewed changes
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jan 2, 2026
@mbinns mbinns force-pushed the update-dfu-programmer branch from 64b0084 to 871c744 Compare January 2, 2026 22:05
@mbinns
Copy link
Contributor Author

mbinns commented Jan 2, 2026

Think I got it right this time, added maintainers and also made the fetchFromGithub not dependent on the derivation name.

@cybardev
Copy link
Contributor

cybardev commented Jan 2, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 476376
Commit: 871c7448ffdda432fe6623a8251ad01dc583718b (subsequent changes)
Merge: 9ae580dbc25bbde3bf146ec3edf9d800c887df39

Logs: https://github.com/cybardev/nixpkgs-review-action/actions/runs/20667912011

x86_64-linux

✅ 3 packages built:
  • dfu-programmer
  • qmk
  • qmk.dist

aarch64-linux

✅ 3 packages built:
  • dfu-programmer
  • qmk
  • qmk.dist

x86_64-darwin (sandbox = relaxed)

✅ 1 package built:
  • dfu-programmer

aarch64-darwin (sandbox = relaxed)

✅ 3 packages built:
  • dfu-programmer
  • qmk
  • qmk.dist

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 2, 2026
@JarvisCraft
Copy link
Contributor

JarvisCraft commented Jan 2, 2026

In favor of building this ASAP since it resolves the recent GCC update issue

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jan 2, 2026
@mbinns mbinns changed the title Update dfu programmer dfu-programmer: 0.7.2 -> 1.1.0 Jan 3, 2026
Aleksanaa
Aleksanaa reviewed Jan 3, 2026
View reviewed changes
@KneeCapStealer
Copy link
Contributor

KneeCapStealer commented Jan 3, 2026

In favor of building this ASAP since it resolves the recent GCC update issue

Canon-cups also depends on this

@mbinns
dfu-programmer: 0.7.2 -> 1.1.0
2772a88 
Fixes migration to GCC 15 and the gnu23 reserved words errors
NixOS#475479
@mbinns mbinns force-pushed the update-dfu-programmer branch from 871c744 to 2772a88 Compare January 4, 2026 00:30
@cybardev
Copy link
Contributor

cybardev commented Jan 4, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 476376
Commit: 2772a883a96441ae80067cfe948a945d197e5dc3 (subsequent changes)
Merge: dfc9bc831d9c163f109ac2bf91e86007dcbd4dde

Logs: https://github.com/cybardev/nixpkgs-review-action/actions/runs/20686963982

x86_64-linux

✅ 3 packages built:
  • dfu-programmer
  • qmk
  • qmk.dist

aarch64-linux

✅ 3 packages built:
  • dfu-programmer
  • qmk
  • qmk.dist

x86_64-darwin (sandbox = relaxed)

✅ 1 package built:
  • dfu-programmer

aarch64-darwin (sandbox = relaxed)

✅ 3 packages built:
  • dfu-programmer
  • qmk
  • qmk.dist

SuperSandro2000
SuperSandro2000 reviewed Jan 4, 2026
View reviewed changes
pkgs/by-name/df/dfu-programmer/package.nix
src = fetchFromGitHub {
owner = "dfu-programmer";
repo = "dfu-programmer";
rev = "v${finalAttrs.version}";
Copy link
Member

@SuperSandro2000 SuperSandro2000 Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = "v${finalAttrs.version}";
tag = "v${finalAttrs.version}";

@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Jan 4, 2026
Merged via the queue into NixOS:master with commit 736e43f Jan 4, 2026
30 of 32 checks passed
sarahec pushed a commit to sarahec/nixpkgs that referenced this pull request Jan 4, 2026
@SuperSandro2000 @sarahec
dfu-programmer: 0.7.2 -> 1.1.0 (NixOS#476376)
682cf2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@Aleksanaa Aleksanaa Aleksanaa left review comments

+2 more reviewers

@JarvisCraft JarvisCraft JarvisCraft approved these changes

@cybardev cybardev cybardev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mbinns @cybardev @JarvisCraft @KneeCapStealer @SuperSandro2000 @Aleksanaa