Skip to content

haskell.lib.buildFromSdist: Allow overrideCabal#48699

Merged
basvandijk merged 1 commit intoNixOS:masterfrom
ElvishJerricco:overridable-buildFromSdist
Oct 26, 2018
Merged

haskell.lib.buildFromSdist: Allow overrideCabal#48699
basvandijk merged 1 commit intoNixOS:masterfrom
ElvishJerricco:overridable-buildFromSdist

Conversation

@ElvishJerricco
Copy link
Copy Markdown
Contributor

Motivation for this change

Fixes #45018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 19, 2018
@basvandijk basvandijk merged commit 945c6b9 into NixOS:master Oct 26, 2018
@basvandijk
Copy link
Copy Markdown
Member

Thank you! I had this problem myself a few times. Nice that the solution is so simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants