Skip to content

nixos/displayManager: slimlock fix (#67350)#67751

Closed
misuzu wants to merge 2 commits intoNixOS:masterfrom
misuzu:slimlock-fix
Closed

nixos/displayManager: slimlock fix (#67350)#67751
misuzu wants to merge 2 commits intoNixOS:masterfrom
misuzu:slimlock-fix

Conversation

@misuzu
Copy link
Copy Markdown
Contributor

@misuzu misuzu commented Aug 30, 2019

Motivation for this change

Allow xautolock to lock session using loginctl lock-session and fix slimlock theme.
See #67350 for details

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 30, 2019
@misuzu misuzu changed the title slimlock fix (#67350) nixos/displayManager: slimlock fix (#67350) Sep 12, 2019
@nixos-discourse
Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-in-distress/3604/5

misuzu added 2 commits October 2, 2019 23:01
…o user systemd session (stolen from home-manager), added XDG_SESSION_ID to default list of variables.
@misuzu
Copy link
Copy Markdown
Contributor Author

misuzu commented Oct 2, 2019

@adisbladis @edolstra @fpletz please take a look at this.

@misuzu misuzu closed this Oct 9, 2019
@misuzu misuzu deleted the slimlock-fix branch October 9, 2019 22:06
@evenbrenden
Copy link
Copy Markdown
Contributor

@misuzu did you close this because #67350 (comment) was a sufficient fix? I ran into the same issue - loginctl lock-session does not trigger xss-lock when run as a service because XDG_SESSION_ID is not set in the systemctl environment (I suppose idle hint management is broken too). I'd like to keep xss-lock as a service (and all the safety that comes with it) rather than launching it through sessionCommands. This PR does the trick and I also think it's tidy to do it the same way as home-manager does.

Would you consider reopening? Or, alternatively, would you mind if a created a new one based on it?

@misuzu
Copy link
Copy Markdown
Contributor Author

misuzu commented Jul 24, 2020

@evenbrenden slim is no longer in nixpkgs, see #75389

@evenbrenden
Copy link
Copy Markdown
Contributor

@evenbrenden slim is no longer in nixpkgs, see #75389

I tested with LightDM and it has the same issue.

@misuzu
Copy link
Copy Markdown
Contributor Author

misuzu commented Jul 24, 2020

would you mind if a created a new one based on it?

Sure, go for it

I tested with LightDM and it has the same issue.

#67350 (comment) is still a good option for the time being

EDIT: sorry, attention issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants