Skip to content

Conversation

@SCOTT-HAMILTON
Copy link
Contributor

Motivation for this change

Needed Compton for a rice.

Things done

Packaged Compton 0.1_beta2, couldn't build the doc.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 8.has: documentation This PR adds or changes documentation label Jul 4, 2020
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 4, 2020
@symphorien
Copy link
Member

I think compton is available in nixpkgs under the new name picom

@SCOTT-HAMILTON
Copy link
Contributor Author

Oh. Sorry, didn't noticed. Also this one isn't upstream Compton, it's a fork. But it provides a new blur method. Should maybe rename it compton-kawase. (name of the new blur method). But in that case I'm not sure if nixpkgs is the right place for it.

@jtojnar
Copy link
Member

jtojnar commented Jul 4, 2020

Yeah, it was renamed in #74831

@jtojnar
Copy link
Member

jtojnar commented Jul 4, 2020

For dual-kawase, there is this pull request against picom: yshui/picom#382

@Philipp-M
Copy link
Member

Anyone interested in using a kawase-blur-activated version can simply use an overlay like this:

{
  nixpkgs.overlays = [
    # add dual kawase blur and rounded corners to picom
    (self: super: {
      picom = super.picom.overrideAttrs (old: {
        src = builtins.fetchTarball {
          url = "https://github.com/ibhagwan/picom/archive/82ecc90b51fa2489d26ef3f08abe1f06efcb53d8.tar.gz";
          sha256 = "0pk1711kd6qqjhghrc73ldjl0m82p53yiiz5acyxvaw55hvm558h";
        };
      });
    })
  ];
}

Sooner or later it will be merged to master anyway so I think we should stick with the mainline picom and probably close this PR?

@SCOTT-HAMILTON
Copy link
Contributor Author

Fair enough, I close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants