Skip to content

scas: init at 0.4.6 #94165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
infinisil merged 2 commits into from
Aug 1, 2020
Merged

scas: init at 0.4.6 #94165

infinisil merged 2 commits into from
Aug 1, 2020

Conversation

@siraben
Copy link
Member

@siraben siraben commented Jul 29, 2020 •
edited
Loading

Motivation for this change

Add scas Z80 assembler

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 29, 2020
sikmir
sikmir reviewed Jul 29, 2020
View reviewed changes
sikmir
sikmir reviewed Jul 29, 2020
View reviewed changes
syberant
syberant reviewed Jul 29, 2020
View reviewed changes
sikmir
sikmir reviewed Jul 29, 2020
View reviewed changes
@siraben siraben requested a review from sikmir July 30, 2020 03:23
@siraben
Copy link
Member Author

siraben commented Jul 31, 2020

Ready to merge.

@infinisil
Copy link
Member

infinisil commented Aug 1, 2020

Please rebase the PR such that it has an initial commit that adds you as a maintainer and a second commit that adds the package

@infinisil infinisil merged commit 64a9b4b into NixOS:master Aug 1, 2020
@siraben siraben deleted the scas branch August 2, 2020 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sikmir sikmir sikmir approved these changes

+1 more reviewer

@syberant syberant syberant left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@siraben @infinisil @sikmir @syberant