Skip to content

[Fix] srtool was failing after the merge of PR #687#698

Merged
Hounsette merged 1 commit intomasterfrom
fixup-srtool-fail
Jan 19, 2023
Merged

[Fix] srtool was failing after the merge of PR #687#698
Hounsette merged 1 commit intomasterfrom
fixup-srtool-fail

Conversation

@Hounsette
Copy link
Copy Markdown
Contributor

@Hounsette Hounsette commented Jan 18, 2023

Cargo.lock file was not updated

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 18, 2023

Codecov Report

Merging #698 (95ee1e8) into master (c7b51d6) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head 95ee1e8 differs from pull request most recent head c1a4a01. Consider uploading reports for the commit c1a4a01 to get more accurate results

@@            Coverage Diff             @@
##           master     #698      +/-   ##
==========================================
- Coverage   77.75%   77.73%   -0.03%     
==========================================
  Files          42       43       +1     
  Lines        7594     7596       +2     
==========================================
  Hits         5905     5905              
- Misses       1689     1691       +2     
Impacted Files Coverage Δ
node/src/chain_spec.rs 0.00% <ø> (ø)
runtimes/eden/src/lib.rs 2.98% <ø> (ø)
runtimes/eden/src/pallets_parachain.rs 0.00% <ø> (ø)
runtimes/eden/src/xcm_config.rs 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Hounsette Hounsette force-pushed the fixup-srtool-fail branch 2 times, most recently from 113b56c to c1a4a01 Compare January 19, 2023 09:49
@Hounsette Hounsette changed the title test: set srtool to run on a PR to master [Fix] srtool was failing after the merge of PR #687 Jan 19, 2023
@Hounsette Hounsette requested review from aliXsed and simonsso January 19, 2023 09:51
Copy link
Copy Markdown
Contributor

@simonsso simonsso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct

The failing codecov can be ignored.

@Hounsette Hounsette merged commit d5bcbbd into master Jan 19, 2023
@Hounsette Hounsette deleted the fixup-srtool-fail branch January 19, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants