Conversation
added 5 commits
January 31, 2023 16:08
aliXsed
reviewed
Jan 31, 2023
added 2 commits
February 1, 2023 21:23
b505d3b to
7f9e623
Compare
added 10 commits
February 2, 2023 01:10
aliXsed
reviewed
Feb 5, 2023
Codecov Report
@@ Coverage Diff @@
## master #700 +/- ##
==========================================
+ Coverage 77.73% 78.20% +0.46%
==========================================
Files 43 43
Lines 7596 7580 -16
==========================================
+ Hits 5905 5928 +23
+ Misses 1691 1652 -39
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
added 9 commits
February 15, 2023 12:26
e7f8f99 to
ccb892d
Compare
fb1cf96 to
401a96b
Compare
dd172bf to
a62c184
Compare
Contributor
|
@simonsso @Hounsette I have prepared a fix for the last item in the description of this pr. But I would rather make it a separate PR. So we only need the benchmarks for this one. |
Contributor
Author
Seems good to me, we can separate the PR |
simonsso
previously approved these changes
Feb 16, 2023
simonsso
approved these changes
Feb 16, 2023
aliXsed
approved these changes
Feb 16, 2023
Contributor
aliXsed
left a comment
There was a problem hiding this comment.
Thanks @Hounsette and @simonsso
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main change:
Removal of wasmtime feature flag see here
Removal of instantiation for the pallet contract rpc see here
Usage of unstable feature for the pallet contract are activable/deactivable by a flag in the config here
Run benchmark
Add fix for ed25519_verify: Support using dalek for historical blocks paritytech/substrate#12661