Skip to content

feat(nodle-parachain): set the dalek end block to be in future #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aliXsed wants to merge 2 commits into from
Closed

feat(nodle-parachain): set the dalek end block to be in future #709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09e64bf
feat(nodle-parachain): enforce dalek verification for old blocks
Feb 26, 2023
9f268f7
docker: create a special image
Feb 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,13 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2
- name: Login to GHCR
if: github.event_name != 'pull_request'
uses: docker/login-action@v2
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Login to DockerHub
if: github.event_name != 'pull_request'
uses: docker/login-action@v2
uses: docker/login-action@v2
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
Expand All @@ -55,6 +53,8 @@ jobs:
with:
context: .
file: './Dockerfile'
push: ${{ github.event_name != 'pull_request' }}
tags: ${{ steps.meta.outputs.tags }}
push: true
tags: |
nodlecode/chain:dalek-zebra-rc2
ghcr.io/nodlecode/chain:dalek-zebra-rc2
labels: ${{ steps.meta.outputs.labels }}
20 changes: 20 additions & 0 deletions node/src/service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,26 @@ where
)?;
let client = Arc::new(client);

// Set the block number until which ed25519-dalek should be used for signature verification
// Check out https://github.com/paritytech/substrate/pull/12661
// TODO https://github.com/NodleCode/chain/issues/703
const EDEN_BLOCK_NUMBER_UNTIL_DALEK_SHOULD_BE_USED: u32 = 2_500_000;
const PARADIS_BLOCK_NUMBER_UNTIL_DALEK_SHOULD_BE_USED: u32 = 2_000_000;
use sc_client_api::ExecutorProvider;
match config.chain_spec.id() {
"para_eden" => client.execution_extensions().set_extensions_factory(
sc_client_api::execution_extensions::ExtensionBeforeBlock::<Block, sp_io::UseDalekExt>::new(
EDEN_BLOCK_NUMBER_UNTIL_DALEK_SHOULD_BE_USED,
),
),
"para_eden_testing_0510" => client.execution_extensions().set_extensions_factory(
sc_client_api::execution_extensions::ExtensionBeforeBlock::<Block, sp_io::UseDalekExt>::new(
PARADIS_BLOCK_NUMBER_UNTIL_DALEK_SHOULD_BE_USED,
),
),
_ => (),
};

let telemetry_worker_handle = telemetry.as_ref().map(|(worker, _)| worker.handle());

let telemetry = telemetry.map(|(worker, telemetry)| {
Expand Down