refactor(NODLMigration): prepare to create GrantsMigration#45
Merged
Conversation
Member
ETeissonniere
left a comment
There was a problem hiding this comment.
Refactoring looks good, though two points of considerations due to memory layout changes (namely the introduction of the ProposalStatus struct):
CheckBridge.s.solwill no longer work with the current bridgeMigrationNFTcontract wouldn't be redeployable with the current bridge
I wonder if it would make sense to try and maintain backward compatibility with the old storage layout as to keep both of these contract/script usable?
Collaborator
Author
@ETeissonniere very good point. I have now changed it to avoid any modifications of the storage layout. |
ETeissonniere
approved these changes
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This a refactor not changing any behaviour according to the tests. I needed this to reuse bridge common functions for grants without duplicating or changing them.