Conversation
ETeissonniere
approved these changes
Jul 25, 2024
Member
ETeissonniere
left a comment
ETeissonniere
left a comment
There was a problem hiding this comment.
This is looking good. Added one general comment which however does not need to be addressed immediately
Comment on lines
+55
to
+64
| _mustBeAnOracle(msg.sender); | ||
| _mustNotHaveExecutedYet(paraTxHash); | ||
|
|
||
| if (_proposalExists(paraTxHash)) { | ||
| _mustNotHaveVotedYet(paraTxHash, msg.sender); | ||
| _mustNotBeChangingParameters(paraTxHash, user, amount, schedules); | ||
| _recordVote(paraTxHash, msg.sender); | ||
| } else { | ||
| _createProposal(paraTxHash, msg.sender, user, amount, schedules); | ||
| } |
Member
There was a problem hiding this comment.
(general comment, not a blocker) I wonder if some of this logic could be moved to your base contract. It sounds very similar to the logic for liquid tokens. It might be a bit too painful/inelegant to do though
Collaborator
Author
There was a problem hiding this comment.
It could, I thought about it. I thought about two solutions. However it would involve more intrusive changes to our audited NODLMigration which I wanted to avoid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contract is zksync side of the bridge from Eden Parachain. The tokens minted here are already burnt on the side of parachain. The implementation follows the same logic as we have had for the migration of free NODL tokens (NODLMigration).
The known limitation of this implementation is that if an oracle creates a vote with wrong parameters the consensus of other oracles can not fix the proposal. This is not expected to happen with our permissioned oracles. But in the worst case scenario, if the bridge doesn't proceed for a proposal, the governance needs to intervene. Until that no unintended consequence is expected.