feat: add click name service by aliXsed · Pull Request #66 · NodleCode/rollup

aliXsed · 2024-11-13T04:34:36Z

Useful info:

clk.eth name info is:

Label hash: 0x3c5cc49c4c05caada7ffe8d159634bd3e1825c59241310705d45e578f33da648
Nodehash: 0x71691213bee783e965b983e04ea3aac38f8277868655e40363711821e5422940

TokenId of clk.eth in NameWrapper is 51296995595488636425956155272184315314353991018314322163154949517603913214272 equal to 0x71691213bee783e965b983e04ea3aac38f8277868655e40363711821e5422940
clk.eth and clickapp.eth both are currently resolved to 0xaD56AaCEb54407803dDA93D6b1ba6b85676A2226. This name is registered and controlled by 0xD4416b13d2b3a9aBae7AcD5D6C2BbDBE25686401
clk.eth's resolver is the PublicResolver at 0x231b0Ee14048e9dCcD1d247744d114a4EB5E8E63
Sepolia L1 DiamondProxy Contract for ZkSync-Era: 0x9A6DE0f62Aa270A8bCB1e2610078650D539B1Ef9
Sepolia L1 StorageVerifier Contract for ZkSync-Era: 0x5490D0FE20E9F93a847c1907f7Fd2adF217bF534
ETH L1 DiamondProxy Contract for ZkSync-Era: 0x32400084C286CF3E17e7B677ea9583e60a000324
Nodle's instance of SparseMerkleTree is deployed at 0xdc5503a345a584382ef9c8dcb015e5ec095c730c
Nodle's instance of StorageProofVerifier is deployed at 0x8e8e263a394d5637a169424f1224c2da7ef406ad
Nodle's Test L2 ClickNameService deployed at 0xAD4360c87275C7De1229A8c3C0567f921c9302b1
Here is the storage layout of ClickNameService:

┌───────────────────────┬─────────────────────────────────┬──────────────┬────────┬─────────────────────────────────────────────────────────────────────────────────────────────────────┬─────┬───────────────────────────────────────────────────┬───────────────┐
│       contract        │         state_variable          │ storage_slot │ offset │                                                type                                                 │ idx │                     artifact                      │ numberOfBytes │
├───────────────────────┼─────────────────────────────────┼──────────────┼────────┼─────────────────────────────────────────────────────────────────────────────────────────────────────┼─────┼───────────────────────────────────────────────────┼───────────────┤
│   ClickNameService    │              _name              │      0       │   0    │                                          t_string_storage                                           │  0  │ /build-info/2dae3c66f2605f8c8b126e96e1bd78d1.json │      32       │
│   ClickNameService    │             _symbol             │      1       │   0    │                                          t_string_storage                                           │  0  │ /build-info/2dae3c66f2605f8c8b126e96e1bd78d1.json │      32       │
│   ClickNameService    │             _owners             │      2       │   0    │                                   t_mapping(t_uint256,t_address)                                    │  0  │ /build-info/2dae3c66f2605f8c8b126e96e1bd78d1.json │      32       │
│   ClickNameService    │            _balances            │      3       │   0    │                                   t_mapping(t_address,t_uint256)                                    │  0  │ /build-info/2dae3c66f2605f8c8b126e96e1bd78d1.json │      32       │
│   ClickNameService    │         _tokenApprovals         │      4       │   0    │                                   t_mapping(t_uint256,t_address)                                    │  0  │ /build-info/2dae3c66f2605f8c8b126e96e1bd78d1.json │      32       │
│   ClickNameService    │       _operatorApprovals        │      5       │   0    │                          t_mapping(t_address,t_mapping(t_address,t_bool))                           │  0  │ /build-info/2dae3c66f2605f8c8b126e96e1bd78d1.json │      32       │
│   ClickNameService    │             _roles              │      6       │   0    │                         t_mapping(t_bytes32,t_struct(RoleData)302_storage)                          │  0  │ /build-info/2dae3c66f2605f8c8b126e96e1bd78d1.json │      32       │
│   ClickNameService    │         expiryDuration          │      7       │   0    │                                              t_uint256                                              │  0  │ /build-info/2dae3c66f2605f8c8b126e96e1bd78d1.json │      32       │
│   ClickNameService    │             expires             │      8       │   0    │                                   t_mapping(t_uint256,t_uint256)                                    │  0  │ /build-info/2dae3c66f2605f8c8b126e96e1bd78d1.json │      32       │

Nodle's Test L1 ClickResolver is deployed at 0x49E1E847a75C00241596CCBdA8cbEE977be4e8eF
An indexer for registered names is deployed at https://test-indexer.nodleprotocol.io/ which can reply to queries like below:

{
  account(id: "0x2e7f3926ae74fdcdcade2c2ab50990c5dafd42bd") {
    eNsByOwnerId {
      nodes {
        name
      }
    }
  }
}

TODO:

…fferent versions of forge

…ames

src/nameservice/ClickNameService.sol

ETeissonniere · 2024-12-03T01:09:13Z

src/nameservice/ClickResolver.sol

+            );
+        } else if (functionSelector == ADDR_MULTICHAIN_SELECTOR) {
+            (, uint256 coinType) = abi.decode(_data[4:], (bytes32, uint256));
+            if (coinType != ZKSYNC_MAINNET_COIN_TYPE) {


(discussed today, adding here for tracking) Shouldn't we have a coin type for testnet too?

This ADDR_MULTICHAIN_SELECTOR path is not used for us now. So no need to do anything for testnet at the moment.

ETeissonniere · 2024-12-03T01:10:23Z

hardhat.config.ts


 import { HardhatUserConfig } from "hardhat/config";

+import "hardhat-storage-layout";


What is this for?

It will enable producing the storage layout for our contracts from which I verified the slot 2 is what needs to be checked for ClickNameService for storage proofs

The command it enables is npx hardhat storage-layout

clk-gateway/package.json

…raightaway

ETeissonniere · 2024-12-10T04:50:38Z

src/nameservice/ClickNameService.sol

+        if (expires[tokenId] <= block.timestamp) {
+            revert NameExpired(owner, expires[tokenId]);
+        }


By default, names should be permanent unless we enable expiry via an admin function

As discussed we will set a super long default expiry during deployment instead

src/nameservice/ClickNameService.sol

ETeissonniere · 2024-12-10T04:57:52Z

clk-gateway/src/index.ts

+      const sub = data.name.split(".")[0];
+      const owner = getAddress(data.owner);
+
+      const response = await clickNameServiceContract.register(owner, sub);


This is where we might want to do manual nonce management (future ticket?)

No manual nonce management just buffering the request and batching them to reduce the likelihood of concurrent registers. I will create a ticket for it.

https://linear.app/nodle/issue/CHA-546

feat: install zksync-storage-proofs lib plus update/tidy-up all libs

f47744d

aliXsed requested a review from ETeissonniere November 14, 2024 21:54

Alex Sedighi added 15 commits November 15, 2024 10:54

Merge branch 'main' into aliX/ens-1

5244e0a

fix(GrantsTest): warping and local variables behave differently in di…

7312b7f

…fferent versions of forge

Merge branch 'aliX/ens-1' of github.com:NodleCode/rollup into aliX/ens-1

0c75d0f

chore: add clave-contracts

0c97d9b

feat: deploy SparseMerkleTree

390de87

fix var name

004292e

feat: deploy storageProofVerifier

38a47c5

feat(ClickNameService): add initial draft

4aec4e1

feat(ClickNameService): allow register to move ownership of expired n…

220fe45

…ames

get hardhat to compile

ba75476

deploy cns

620692c

feat(ClickResolver): add L1 Resolver contract

1e16e1d

feat: set resolver automatically on deployment of ClickResolver

b9e2c0d

feat: add clk-gateway api server

938685c

feat(clk-gateway): add expiry end point

477346e

aliXsed changed the title ~~feat: install zksync-storage-proofs lib plus update/tidy-up all libs~~ feat: add click name service Nov 26, 2024

Alex Sedighi added 12 commits November 27, 2024 12:22

feat: add L2 resolve api

a8b084f

feat: add registerL2

487dc45

feat: load config from env

0c45a3f

build: container

9ea1615

fix: github actions

bc7f717

fix docker build cmd

78eed09

fix push container

cbcfbfb

feat: add resolveL2 GET

da95ee7

feat: validate api input

767d460

chore: fix spellings

944aec1

fix: forge test

03384e8

fix spell

f4ab097

Alex Sedighi added 3 commits November 28, 2024 17:02

feat: require email verified authentication only for /register

86c4004

feat: add id token creator tool for testing

37c6b10

feat: resolveWithProofL1

e0634a2

ETeissonniere requested changes Dec 3, 2024

View reviewed changes

Alex Sedighi added 13 commits December 3, 2024 16:48

feat(ClickNameService): use well defined errors

6923cf8

feat(ClickResolver): simplify resolver

227f019

feat: separate fetching proof from presenting proof to ClickResolver

6af46c3

feat: use express-validator

a0a06bb

chore: remove submodule clave-contracts

4f10004

feat: add resolveL1 and decode OffchainLookup error

eacc6c6

fix: ClickResolver needs to return data usable by offchain gateway st…

0da3d4c

…raightaway

fix domain env vars

a1ed236

--no-cache

801493d

no crash is a good crash

739d2ba

Google doesn't like GET with body

957a8a5

feat: enable full cors

01aecd5

feat(clk-gateway): allow only one name per verified email

16919ed

ETeissonniere reviewed Dec 10, 2024

View reviewed changes

Alex Sedighi added 6 commits December 11, 2024 12:24

Avoid using sol modifiers

30751cb

reuse registerWithExpiry

dcc47c0

use ts-node

c088359

fix spelling

e4461a0

limit names to 5 characters or more

bc9146b

Merge branch 'main' into aliX/ens-1

7c08ec1

aliXsed marked this pull request as ready for review December 11, 2024 00:12

fix spelling

281e4ad

aliXsed merged commit a3e656e into main Dec 11, 2024

aliXsed deleted the aliX/ens-1 branch December 11, 2024 00:31


		import { HardhatUserConfig } from "hardhat/config";

		import "hardhat-storage-layout";

Conversation

aliXsed commented Nov 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aliXsed Dec 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aliXsed Dec 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

aliXsed commented Nov 13, 2024 •

edited

Loading

aliXsed Dec 10, 2024 •

edited

Loading

aliXsed Dec 10, 2024 •

edited

Loading